PMD Results

The following document contains the results of PMD

Files

net/sf/ehcache/Status.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method152

net/sf/ehcache/CacheManager.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.545

net/sf/ehcache/hibernate/EhCache.java

ViolationLine
Unnecessary final modifier in final class75 - 75
A method should have only one exit point, and that should be the last statement in the method81
A method should have only one exit point, and that should be the last statement in the method88
Unnecessary final modifier in final class105 - 105
Unnecessary final modifier in final class117 - 117
Unnecessary final modifier in final class128 - 128
Unnecessary final modifier in final class148 - 148
Unnecessary final modifier in final class163 - 163
Unnecessary final modifier in final class178 - 178
Unnecessary final modifier in final class194 - 194
Unnecessary final modifier in final class203 - 203
Unnecessary final modifier in final class210 - 210
Unnecessary final modifier in final class217 - 217
Unnecessary final modifier in final class225 - 225
Unnecessary final modifier in final class237 - 237
A method should have only one exit point, and that should be the last statement in the method239
Unnecessary final modifier in final class248 - 248
Unnecessary final modifier in final class259 - 259
Unnecessary final modifier in final class267 - 267
Unnecessary final modifier in final class284 - 284
Unnecessary final modifier in final class291 - 291

net/sf/ehcache/hibernate/EhCacheProvider.java

ViolationLine
Each class should declare at least one constructor55 - 55
Unnecessary final modifier in final class85 - 85
Unnecessary final modifier in final class103 - 103
Unnecessary final modifier in final class114 - 114
Unnecessary final modifier in final class158 - 158
Assigning an Object to null is a code smell. Consider refactoring.161
Unnecessary final modifier in final class170 - 170

net/sf/ehcache/config/FactoryConfiguration.java

ViolationLine
Each class should declare at least one constructor24 - 24

net/sf/ehcache/config/ConfigurationHelper.java

ViolationLine
Avoid empty catch blocks104 - 104
Unnecessary final modifier in final class121 - 121
Avoid empty catch blocks127 - 127
A method should have only one exit point, and that should be the last statement in the method132
Unnecessary final modifier in final class145 - 145
Avoid empty catch blocks151 - 151
A method should have only one exit point, and that should be the last statement in the method156
Unnecessary final modifier in final class170 - 170
Avoid empty catch blocks176 - 176
A method should have only one exit point, and that should be the last statement in the method181
Unnecessary final modifier in final class193 - 193
A method should have only one exit point, and that should be the last statement in the method196
Unnecessary final modifier in final class206 - 206
Unnecessary final modifier in final class221 - 221
Unnecessary final modifier in final class238 - 238
A method should have only one exit point, and that should be the last statement in the method250
Unnecessary final modifier in final class261 - 261
Unnecessary final modifier in final class281 - 281

net/sf/ehcache/config/Configuration.java

ViolationLine
Avoid unnecessary constructors - the compiler will generate these for you46
Unnecessary final modifier in final class52 - 52
Unnecessary final modifier in final class62 - 62
Unnecessary final modifier in final class72 - 72
Unnecessary final modifier in final class83 - 83
Unnecessary final modifier in final class93 - 93
Unnecessary final modifier in final class103 - 103
Unnecessary final modifier in final class118 - 118
Unnecessary final modifier in final class125 - 125
Unnecessary final modifier in final class133 - 133
Unnecessary final modifier in final class141 - 141
Unnecessary final modifier in final class148 - 148
Unnecessary final modifier in final class155 - 155
Unnecessary final modifier in final class162 - 162
Unnecessary final modifier in final class169 - 169
Unnecessary final modifier in final class178 - 178
Unnecessary final modifier in final class185 - 185

net/sf/ehcache/config/DiskStoreConfiguration.java

ViolationLine
Each class should declare at least one constructor28 - 28
Unnecessary final modifier in final class36 - 36
Unnecessary final modifier in final class52 - 52
Each class should declare at least one constructor54 - 54
Use explicit scoping instead of the default package private level55
Use explicit scoping instead of the default package private level56
Use explicit scoping instead of the default package private level57
A method should have only one exit point, and that should be the last statement in the method73

net/sf/ehcache/config/BeanHandler.java

ViolationLine
It is a good practice to call super() in a constructor46 - 46
Unnecessary final modifier in final class53 - 53
Unnecessary final modifier in final class60 - 60
Unnecessary final modifier in final class84 - 84
A method should have only one exit point, and that should be the last statement in the method105
A method should have only one exit point, and that should be the last statement in the method152
A method should have only one exit point, and that should be the last statement in the method178
A method should have only one exit point, and that should be the last statement in the method228
A method should have only one exit point, and that should be the last statement in the method231
A method should have only one exit point, and that should be the last statement in the method234
A method should have only one exit point, and that should be the last statement in the method237
It is a good practice to call super() in a constructor315 - 315
It is a good practice to call super() in a constructor321 - 321

net/sf/ehcache/config/CacheConfiguration.java

ViolationLine
Each class should declare at least one constructor39 - 39
Unnecessary final modifier in final class113 - 113
Unnecessary final modifier in final class120 - 120
Unnecessary final modifier in final class127 - 127
Unnecessary final modifier in final class134 - 134
Unnecessary final modifier in final class141 - 141
Unnecessary final modifier in final class148 - 148
Unnecessary final modifier in final class155 - 155
Unnecessary final modifier in final class162 - 162
Unnecessary final modifier in final class173 - 173
Each class should declare at least one constructor180 - 180
Unnecessary final modifier in final class186 - 186

net/sf/ehcache/Cache.java

ViolationLine
Perhaps 'guid' could be replaced by a local variable.177
Unnecessary final modifier in final class334 - 334
These nested if statements could be combined341 - 341
These nested if statements could be combined365 - 365
Assigning an Object to null is a code smell. Consider refactoring.390
Assigning an Object to null is a code smell. Consider refactoring.417
Unnecessary final modifier in final class439 - 439
Unnecessary final modifier in final class464 - 464
Unnecessary final modifier in final class503 - 503
Unnecessary final modifier in final class528 - 528
Unnecessary final modifier in final class545 - 545
A method should have only one exit point, and that should be the last statement in the method559
Unnecessary final modifier in final class576 - 576
Unnecessary final modifier in final class591 - 591
A method should have only one exit point, and that should be the last statement in the method605
Unnecessary final modifier in final class625 - 625
Unnecessary final modifier in final class672 - 672
Unnecessary final modifier in final class706 - 706
Assigning an Object to null is a code smell. Consider refactoring.732
A method should have only one exit point, and that should be the last statement in the method742
Assigning an Object to null is a code smell. Consider refactoring.758
Unnecessary final modifier in final class779 - 779
Unnecessary final modifier in final class795 - 795
Unnecessary final modifier in final class814 - 814
Unnecessary final modifier in final class831 - 831
Unnecessary final modifier in final class844 - 844
Unnecessary final modifier in final class858 - 858
A method should have only one exit point, and that should be the last statement in the method899
Unnecessary final modifier in final class923 - 923
Unnecessary final modifier in final class938 - 938
Assigning an Object to null is a code smell. Consider refactoring.941
Assigning an Object to null is a code smell. Consider refactoring.944
Unnecessary final modifier in final class962 - 962
Unnecessary final modifier in final class1000 - 1000
Unnecessary final modifier in final class1018 - 1018
Unnecessary final modifier in final class1030 - 1030
Unnecessary final modifier in final class1041 - 1041
A method should have only one exit point, and that should be the last statement in the method1044
Unnecessary final modifier in final class1055 - 1055
Unnecessary final modifier in final class1073 - 1073
Unnecessary final modifier in final class1085 - 1085
Unnecessary final modifier in final class1095 - 1095
Unnecessary final modifier in final class1107 - 1107
Unnecessary final modifier in final class1117 - 1117
Unnecessary final modifier in final class1125 - 1125
Unnecessary final modifier in final class1134 - 1134
Unnecessary final modifier in final class1141 - 1141
Unnecessary final modifier in final class1148 - 1148
Unnecessary final modifier in final class1155 - 1155
Unnecessary final modifier in final class1162 - 1162
Unnecessary final modifier in final class1169 - 1169
Unnecessary final modifier in final class1185 - 1185
Unnecessary final modifier in final class1192 - 1192
Unnecessary final modifier in final class1232 - 1232
Unnecessary final modifier in final class1295 - 1295
Unnecessary final modifier in final class1315 - 1315
Unnecessary final modifier in final class1325 - 1325
Unnecessary final modifier in final class1333 - 1333
Unnecessary final modifier in final class1342 - 1342
Unnecessary final modifier in final class1351 - 1351
Unnecessary final modifier in final class1361 - 1361
Unnecessary final modifier in final class1371 - 1371
Unnecessary final modifier in final class1380 - 1380
Unnecessary final modifier in final class1390 - 1390
A method should have only one exit point, and that should be the last statement in the method1392
Unnecessary final modifier in final class1405 - 1405
Unnecessary final modifier in final class1415 - 1415
Unnecessary final modifier in final class1424 - 1424

net/sf/ehcache/event/RegisteredEventListeners.java

ViolationLine
Unnecessary final modifier in final class64 - 64
Unnecessary final modifier in final class81 - 81
Unnecessary final modifier in final class98 - 98
Unnecessary final modifier in final class115 - 115
Unnecessary final modifier in final class146 - 146
A method should have only one exit point, and that should be the last statement in the method148
Unnecessary final modifier in final class159 - 159
Unnecessary final modifier in final class168 - 168
Unnecessary final modifier in final class177 - 177
Unnecessary final modifier in final class196 - 196

net/sf/ehcache/event/CacheManagerEventListenerFactory.java

ViolationLine
Each class should declare at least one constructor28 - 28

net/sf/ehcache/event/CacheEventListenerFactory.java

ViolationLine
Each class should declare at least one constructor28 - 28

net/sf/ehcache/store/MemoryStore.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method174
Assigning an Object to null is a code smell. Consider refactoring.232

net/sf/ehcache/store/LfuMemoryStore.java

ViolationLine
Perhaps 'random' could be replaced by a local variable.59
Unnecessary final modifier in final class72 - 72
Unnecessary final modifier in final class102 - 102
A method should have only one exit point, and that should be the last statement in the method109
Unnecessary final modifier in final class122 - 122
A method should have only one exit point, and that should be the last statement in the method138

net/sf/ehcache/store/LruMemoryStore.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method73
It is a good practice to call super() in a constructor110 - 110
Unnecessary final modifier in final class124 - 124
Unnecessary final modifier in final class187 - 187
A method should have only one exit point, and that should be the last statement in the method202
A method should have only one exit point, and that should be the last statement in the method207

net/sf/ehcache/store/MemoryStoreEvictionPolicy.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method84
A method should have only one exit point, and that should be the last statement in the method86
A method should have only one exit point, and that should be the last statement in the method88

net/sf/ehcache/store/FifoMemoryStore.java

ViolationLine
Unnecessary final modifier in final class80 - 80
A method should have only one exit point, and that should be the last statement in the method93

net/sf/ehcache/store/DiskStore.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.175
A method should have only one exit point, and that should be the last statement in the method216
A method should have only one exit point, and that should be the last statement in the method223
A method should have only one exit point, and that should be the last statement in the method228
A method should have only one exit point, and that should be the last statement in the method281
A method should have only one exit point, and that should be the last statement in the method288
A method should have only one exit point, and that should be the last statement in the method293
A method should have only one exit point, and that should be the last statement in the method339
Assigning an Object to null is a code smell. Consider refactoring.505
Assigning an Object to null is a code smell. Consider refactoring.509
A method should have only one exit point, and that should be the last statement in the method547
Assigning an Object to null is a code smell. Consider refactoring.579
Assigning an Object to null is a code smell. Consider refactoring.621
Avoid empty catch blocks691 - 691
A method should have only one exit point, and that should be the last statement in the method903
Each class should declare at least one constructor929 - 929
Unnecessary final modifier in final class968 - 968
Unnecessary final modifier in final class986 - 986
A method should have only one exit point, and that should be the last statement in the method1031
A method should have only one exit point, and that should be the last statement in the method1070

net/sf/ehcache/util/PropertyUtil.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method47
A method should have only one exit point, and that should be the last statement in the method68

net/sf/ehcache/Element.java

ViolationLine
Unnecessary final modifier in final class141 - 141
Unnecessary final modifier in final class160 - 160
Unnecessary final modifier in final class170 - 170
Unnecessary final modifier in final class190 - 190
Unnecessary final modifier in final class197 - 197
A method should have only one exit point, and that should be the last statement in the method199
A method should have only one exit point, and that should be the last statement in the method204
Unnecessary final modifier in final class213 - 213
Unnecessary final modifier in final class222 - 222
Unnecessary final modifier in final class231 - 231
Unnecessary final modifier in final class238 - 238
Unnecessary final modifier in final class247 - 247
Unnecessary final modifier in final class256 - 256
Unnecessary final modifier in final class266 - 266
Unnecessary final modifier in final class273 - 273
Unnecessary final modifier in final class280 - 280
Unnecessary final modifier in final class289 - 289
Unnecessary final modifier in final class298 - 298
Unnecessary final modifier in final class323 - 323
Unnecessary final modifier in final class376 - 376
A method should have only one exit point, and that should be the last statement in the method378
A method should have only one exit point, and that should be the last statement in the method387
Unnecessary final modifier in final class412 - 412
Unnecessary final modifier in final class427 - 427

net/sf/ehcache/distribution/RMICacheReplicatorFactory.java

ViolationLine
Each class should declare at least one constructor39 - 39
Unnecessary final modifier in final class72 - 72
A method should have only one exit point, and that should be the last statement in the method80 - 80

net/sf/ehcache/distribution/CacheManagerPeerProviderFactory.java

ViolationLine
Each class should declare at least one constructor29 - 29

net/sf/ehcache/distribution/ManualRMICacheManagerPeerProvider.java

ViolationLine
Avoid unnecessary constructors - the compiler will generate these for you47 - 47
Unnecessary final modifier in final class54 - 54
Unnecessary final modifier in final class63 - 63
Unnecessary final modifier in final class71 - 71
Unnecessary final modifier in final class120 - 120

net/sf/ehcache/distribution/RMISynchronousCacheReplicator.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method105
A method should have only one exit point, and that should be the last statement in the method109
A method should have only one exit point, and that should be the last statement in the method157
A method should have only one exit point, and that should be the last statement in the method160
A method should have only one exit point, and that should be the last statement in the method168
A method should have only one exit point, and that should be the last statement in the method198
A method should have only one exit point, and that should be the last statement in the method202
This statement may have some unnecessary parentheses275

net/sf/ehcache/distribution/MulticastKeepaliveHeartbeatSender.java

ViolationLine
Unnecessary final modifier in final class67 - 67
Unnecessary final modifier in final class75 - 75
Perhaps 'compressedUrlList' could be replaced by a local variable.87
Perhaps 'cachePeersHash' could be replaced by a local variable.88
Unnecessary final modifier in final class99 - 99
Unnecessary final modifier in final class185 - 185

net/sf/ehcache/distribution/RMICacheManagerPeerListenerFactory.java

ViolationLine
Each class should declare at least one constructor38 - 38
Unnecessary final modifier in final class54 - 54

net/sf/ehcache/distribution/EventMessage.java

ViolationLine
Unnecessary final modifier in final class77 - 77
Unnecessary final modifier in final class84 - 84
Unnecessary final modifier in final class91 - 91

net/sf/ehcache/distribution/MulticastRMICacheManagerPeerProvider.java

ViolationLine
Unnecessary final modifier in final class88 - 88
Unnecessary final modifier in final class102 - 102
Unnecessary final modifier in final class130 - 130
Unnecessary final modifier in final class171 - 171
Unnecessary final modifier in final class184 - 184
It is a good practice to call super() in a constructor204 - 204
Unnecessary final modifier in final class212 - 212
Unnecessary final modifier in final class220 - 220

net/sf/ehcache/distribution/CacheManagerPeerListenerFactory.java

ViolationLine
Each class should declare at least one constructor31 - 31

net/sf/ehcache/distribution/RMICacheManagerPeerProviderFactory.java

ViolationLine
Each class should declare at least one constructor35 - 35
Unnecessary final modifier in final class51 - 51
A method should have only one exit point, and that should be the last statement in the method56
A method should have only one exit point, and that should be the last statement in the method61

net/sf/ehcache/distribution/RMIAsynchronousCacheReplicator.java

ViolationLine
A method should have only one exit point, and that should be the last statement in the method110
Unnecessary final modifier in final class136 - 136
A method should have only one exit point, and that should be the last statement in the method138
A method should have only one exit point, and that should be the last statement in the method142
Unnecessary final modifier in final class168 - 168
A method should have only one exit point, and that should be the last statement in the method170
A method should have only one exit point, and that should be the last statement in the method173
A method should have only one exit point, and that should be the last statement in the method181
Unnecessary final modifier in final class204 - 204
A method should have only one exit point, and that should be the last statement in the method206
Unnecessary final modifier in final class331 - 331
It is a good practice to call super() in a constructor348 - 348
Unnecessary final modifier in final class357 - 357
Unnecessary final modifier in final class366 - 366

net/sf/ehcache/distribution/RMICacheManagerPeerListener.java

ViolationLine
Unnecessary final modifier in final class118 - 118
Unnecessary final modifier in final class145 - 145
Unnecessary final modifier in final class157 - 157
A method should have only one exit point, and that should be the last statement in the method192
Unnecessary final modifier in final class232 - 232
Unnecessary final modifier in final class250 - 250
Unnecessary final modifier in final class257 - 257

net/sf/ehcache/distribution/MulticastKeepaliveHeartbeatReceiver.java

ViolationLine
Unnecessary final modifier in final class67 - 67
Unnecessary final modifier in final class78 - 78
Each class should declare at least one constructor87 - 87
Unnecessary final modifier in final class91 - 91
Unnecessary final modifier in final class153 - 153