The following document contains the results of PMD
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 152 |
Violation | Line |
---|---|
Assigning an Object to null is a code smell. Consider refactoring. | 545 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 75 - 75 |
A method should have only one exit point, and that should be the last statement in the method | 81 |
A method should have only one exit point, and that should be the last statement in the method | 88 |
Unnecessary final modifier in final class | 105 - 105 |
Unnecessary final modifier in final class | 117 - 117 |
Unnecessary final modifier in final class | 128 - 128 |
Unnecessary final modifier in final class | 148 - 148 |
Unnecessary final modifier in final class | 163 - 163 |
Unnecessary final modifier in final class | 178 - 178 |
Unnecessary final modifier in final class | 194 - 194 |
Unnecessary final modifier in final class | 203 - 203 |
Unnecessary final modifier in final class | 210 - 210 |
Unnecessary final modifier in final class | 217 - 217 |
Unnecessary final modifier in final class | 225 - 225 |
Unnecessary final modifier in final class | 237 - 237 |
A method should have only one exit point, and that should be the last statement in the method | 239 |
Unnecessary final modifier in final class | 248 - 248 |
Unnecessary final modifier in final class | 259 - 259 |
Unnecessary final modifier in final class | 267 - 267 |
Unnecessary final modifier in final class | 284 - 284 |
Unnecessary final modifier in final class | 291 - 291 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 55 - 55 |
Unnecessary final modifier in final class | 85 - 85 |
Unnecessary final modifier in final class | 103 - 103 |
Unnecessary final modifier in final class | 114 - 114 |
Unnecessary final modifier in final class | 158 - 158 |
Assigning an Object to null is a code smell. Consider refactoring. | 161 |
Unnecessary final modifier in final class | 170 - 170 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 24 - 24 |
Violation | Line |
---|---|
Avoid empty catch blocks | 104 - 104 |
Unnecessary final modifier in final class | 121 - 121 |
Avoid empty catch blocks | 127 - 127 |
A method should have only one exit point, and that should be the last statement in the method | 132 |
Unnecessary final modifier in final class | 145 - 145 |
Avoid empty catch blocks | 151 - 151 |
A method should have only one exit point, and that should be the last statement in the method | 156 |
Unnecessary final modifier in final class | 170 - 170 |
Avoid empty catch blocks | 176 - 176 |
A method should have only one exit point, and that should be the last statement in the method | 181 |
Unnecessary final modifier in final class | 193 - 193 |
A method should have only one exit point, and that should be the last statement in the method | 196 |
Unnecessary final modifier in final class | 206 - 206 |
Unnecessary final modifier in final class | 221 - 221 |
Unnecessary final modifier in final class | 238 - 238 |
A method should have only one exit point, and that should be the last statement in the method | 250 |
Unnecessary final modifier in final class | 261 - 261 |
Unnecessary final modifier in final class | 281 - 281 |
Violation | Line |
---|---|
Avoid unnecessary constructors - the compiler will generate these for you | 46 |
Unnecessary final modifier in final class | 52 - 52 |
Unnecessary final modifier in final class | 62 - 62 |
Unnecessary final modifier in final class | 72 - 72 |
Unnecessary final modifier in final class | 83 - 83 |
Unnecessary final modifier in final class | 93 - 93 |
Unnecessary final modifier in final class | 103 - 103 |
Unnecessary final modifier in final class | 118 - 118 |
Unnecessary final modifier in final class | 125 - 125 |
Unnecessary final modifier in final class | 133 - 133 |
Unnecessary final modifier in final class | 141 - 141 |
Unnecessary final modifier in final class | 148 - 148 |
Unnecessary final modifier in final class | 155 - 155 |
Unnecessary final modifier in final class | 162 - 162 |
Unnecessary final modifier in final class | 169 - 169 |
Unnecessary final modifier in final class | 178 - 178 |
Unnecessary final modifier in final class | 185 - 185 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 28 - 28 |
Unnecessary final modifier in final class | 36 - 36 |
Unnecessary final modifier in final class | 52 - 52 |
Each class should declare at least one constructor | 54 - 54 |
Use explicit scoping instead of the default package private level | 55 |
Use explicit scoping instead of the default package private level | 56 |
Use explicit scoping instead of the default package private level | 57 |
A method should have only one exit point, and that should be the last statement in the method | 73 |
Violation | Line |
---|---|
It is a good practice to call super() in a constructor | 46 - 46 |
Unnecessary final modifier in final class | 53 - 53 |
Unnecessary final modifier in final class | 60 - 60 |
Unnecessary final modifier in final class | 84 - 84 |
A method should have only one exit point, and that should be the last statement in the method | 105 |
A method should have only one exit point, and that should be the last statement in the method | 152 |
A method should have only one exit point, and that should be the last statement in the method | 178 |
A method should have only one exit point, and that should be the last statement in the method | 228 |
A method should have only one exit point, and that should be the last statement in the method | 231 |
A method should have only one exit point, and that should be the last statement in the method | 234 |
A method should have only one exit point, and that should be the last statement in the method | 237 |
It is a good practice to call super() in a constructor | 315 - 315 |
It is a good practice to call super() in a constructor | 321 - 321 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 39 - 39 |
Unnecessary final modifier in final class | 113 - 113 |
Unnecessary final modifier in final class | 120 - 120 |
Unnecessary final modifier in final class | 127 - 127 |
Unnecessary final modifier in final class | 134 - 134 |
Unnecessary final modifier in final class | 141 - 141 |
Unnecessary final modifier in final class | 148 - 148 |
Unnecessary final modifier in final class | 155 - 155 |
Unnecessary final modifier in final class | 162 - 162 |
Unnecessary final modifier in final class | 173 - 173 |
Each class should declare at least one constructor | 180 - 180 |
Unnecessary final modifier in final class | 186 - 186 |
Violation | Line |
---|---|
Perhaps 'guid' could be replaced by a local variable. | 177 |
Unnecessary final modifier in final class | 334 - 334 |
These nested if statements could be combined | 341 - 341 |
These nested if statements could be combined | 365 - 365 |
Assigning an Object to null is a code smell. Consider refactoring. | 390 |
Assigning an Object to null is a code smell. Consider refactoring. | 417 |
Unnecessary final modifier in final class | 439 - 439 |
Unnecessary final modifier in final class | 464 - 464 |
Unnecessary final modifier in final class | 503 - 503 |
Unnecessary final modifier in final class | 528 - 528 |
Unnecessary final modifier in final class | 545 - 545 |
A method should have only one exit point, and that should be the last statement in the method | 559 |
Unnecessary final modifier in final class | 576 - 576 |
Unnecessary final modifier in final class | 591 - 591 |
A method should have only one exit point, and that should be the last statement in the method | 605 |
Unnecessary final modifier in final class | 625 - 625 |
Unnecessary final modifier in final class | 672 - 672 |
Unnecessary final modifier in final class | 706 - 706 |
Assigning an Object to null is a code smell. Consider refactoring. | 732 |
A method should have only one exit point, and that should be the last statement in the method | 742 |
Assigning an Object to null is a code smell. Consider refactoring. | 758 |
Unnecessary final modifier in final class | 779 - 779 |
Unnecessary final modifier in final class | 795 - 795 |
Unnecessary final modifier in final class | 814 - 814 |
Unnecessary final modifier in final class | 831 - 831 |
Unnecessary final modifier in final class | 844 - 844 |
Unnecessary final modifier in final class | 858 - 858 |
A method should have only one exit point, and that should be the last statement in the method | 899 |
Unnecessary final modifier in final class | 923 - 923 |
Unnecessary final modifier in final class | 938 - 938 |
Assigning an Object to null is a code smell. Consider refactoring. | 941 |
Assigning an Object to null is a code smell. Consider refactoring. | 944 |
Unnecessary final modifier in final class | 962 - 962 |
Unnecessary final modifier in final class | 1000 - 1000 |
Unnecessary final modifier in final class | 1018 - 1018 |
Unnecessary final modifier in final class | 1030 - 1030 |
Unnecessary final modifier in final class | 1041 - 1041 |
A method should have only one exit point, and that should be the last statement in the method | 1044 |
Unnecessary final modifier in final class | 1055 - 1055 |
Unnecessary final modifier in final class | 1073 - 1073 |
Unnecessary final modifier in final class | 1085 - 1085 |
Unnecessary final modifier in final class | 1095 - 1095 |
Unnecessary final modifier in final class | 1107 - 1107 |
Unnecessary final modifier in final class | 1117 - 1117 |
Unnecessary final modifier in final class | 1125 - 1125 |
Unnecessary final modifier in final class | 1134 - 1134 |
Unnecessary final modifier in final class | 1141 - 1141 |
Unnecessary final modifier in final class | 1148 - 1148 |
Unnecessary final modifier in final class | 1155 - 1155 |
Unnecessary final modifier in final class | 1162 - 1162 |
Unnecessary final modifier in final class | 1169 - 1169 |
Unnecessary final modifier in final class | 1185 - 1185 |
Unnecessary final modifier in final class | 1192 - 1192 |
Unnecessary final modifier in final class | 1232 - 1232 |
Unnecessary final modifier in final class | 1295 - 1295 |
Unnecessary final modifier in final class | 1315 - 1315 |
Unnecessary final modifier in final class | 1325 - 1325 |
Unnecessary final modifier in final class | 1333 - 1333 |
Unnecessary final modifier in final class | 1342 - 1342 |
Unnecessary final modifier in final class | 1351 - 1351 |
Unnecessary final modifier in final class | 1361 - 1361 |
Unnecessary final modifier in final class | 1371 - 1371 |
Unnecessary final modifier in final class | 1380 - 1380 |
Unnecessary final modifier in final class | 1390 - 1390 |
A method should have only one exit point, and that should be the last statement in the method | 1392 |
Unnecessary final modifier in final class | 1405 - 1405 |
Unnecessary final modifier in final class | 1415 - 1415 |
Unnecessary final modifier in final class | 1424 - 1424 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 64 - 64 |
Unnecessary final modifier in final class | 81 - 81 |
Unnecessary final modifier in final class | 98 - 98 |
Unnecessary final modifier in final class | 115 - 115 |
Unnecessary final modifier in final class | 146 - 146 |
A method should have only one exit point, and that should be the last statement in the method | 148 |
Unnecessary final modifier in final class | 159 - 159 |
Unnecessary final modifier in final class | 168 - 168 |
Unnecessary final modifier in final class | 177 - 177 |
Unnecessary final modifier in final class | 196 - 196 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 28 - 28 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 28 - 28 |
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 174 |
Assigning an Object to null is a code smell. Consider refactoring. | 232 |
Violation | Line |
---|---|
Perhaps 'random' could be replaced by a local variable. | 59 |
Unnecessary final modifier in final class | 72 - 72 |
Unnecessary final modifier in final class | 102 - 102 |
A method should have only one exit point, and that should be the last statement in the method | 109 |
Unnecessary final modifier in final class | 122 - 122 |
A method should have only one exit point, and that should be the last statement in the method | 138 |
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 73 |
It is a good practice to call super() in a constructor | 110 - 110 |
Unnecessary final modifier in final class | 124 - 124 |
Unnecessary final modifier in final class | 187 - 187 |
A method should have only one exit point, and that should be the last statement in the method | 202 |
A method should have only one exit point, and that should be the last statement in the method | 207 |
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 84 |
A method should have only one exit point, and that should be the last statement in the method | 86 |
A method should have only one exit point, and that should be the last statement in the method | 88 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 80 - 80 |
A method should have only one exit point, and that should be the last statement in the method | 93 |
Violation | Line |
---|---|
Assigning an Object to null is a code smell. Consider refactoring. | 175 |
A method should have only one exit point, and that should be the last statement in the method | 216 |
A method should have only one exit point, and that should be the last statement in the method | 223 |
A method should have only one exit point, and that should be the last statement in the method | 228 |
A method should have only one exit point, and that should be the last statement in the method | 281 |
A method should have only one exit point, and that should be the last statement in the method | 288 |
A method should have only one exit point, and that should be the last statement in the method | 293 |
A method should have only one exit point, and that should be the last statement in the method | 339 |
Assigning an Object to null is a code smell. Consider refactoring. | 505 |
Assigning an Object to null is a code smell. Consider refactoring. | 509 |
A method should have only one exit point, and that should be the last statement in the method | 547 |
Assigning an Object to null is a code smell. Consider refactoring. | 579 |
Assigning an Object to null is a code smell. Consider refactoring. | 621 |
Avoid empty catch blocks | 691 - 691 |
A method should have only one exit point, and that should be the last statement in the method | 903 |
Each class should declare at least one constructor | 929 - 929 |
Unnecessary final modifier in final class | 968 - 968 |
Unnecessary final modifier in final class | 986 - 986 |
A method should have only one exit point, and that should be the last statement in the method | 1031 |
A method should have only one exit point, and that should be the last statement in the method | 1070 |
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 47 |
A method should have only one exit point, and that should be the last statement in the method | 68 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 141 - 141 |
Unnecessary final modifier in final class | 160 - 160 |
Unnecessary final modifier in final class | 170 - 170 |
Unnecessary final modifier in final class | 190 - 190 |
Unnecessary final modifier in final class | 197 - 197 |
A method should have only one exit point, and that should be the last statement in the method | 199 |
A method should have only one exit point, and that should be the last statement in the method | 204 |
Unnecessary final modifier in final class | 213 - 213 |
Unnecessary final modifier in final class | 222 - 222 |
Unnecessary final modifier in final class | 231 - 231 |
Unnecessary final modifier in final class | 238 - 238 |
Unnecessary final modifier in final class | 247 - 247 |
Unnecessary final modifier in final class | 256 - 256 |
Unnecessary final modifier in final class | 266 - 266 |
Unnecessary final modifier in final class | 273 - 273 |
Unnecessary final modifier in final class | 280 - 280 |
Unnecessary final modifier in final class | 289 - 289 |
Unnecessary final modifier in final class | 298 - 298 |
Unnecessary final modifier in final class | 323 - 323 |
Unnecessary final modifier in final class | 376 - 376 |
A method should have only one exit point, and that should be the last statement in the method | 378 |
A method should have only one exit point, and that should be the last statement in the method | 387 |
Unnecessary final modifier in final class | 412 - 412 |
Unnecessary final modifier in final class | 427 - 427 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 39 - 39 |
Unnecessary final modifier in final class | 72 - 72 |
A method should have only one exit point, and that should be the last statement in the method | 80 - 80 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 29 - 29 |
Violation | Line |
---|---|
Avoid unnecessary constructors - the compiler will generate these for you | 47 - 47 |
Unnecessary final modifier in final class | 54 - 54 |
Unnecessary final modifier in final class | 63 - 63 |
Unnecessary final modifier in final class | 71 - 71 |
Unnecessary final modifier in final class | 120 - 120 |
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 105 |
A method should have only one exit point, and that should be the last statement in the method | 109 |
A method should have only one exit point, and that should be the last statement in the method | 157 |
A method should have only one exit point, and that should be the last statement in the method | 160 |
A method should have only one exit point, and that should be the last statement in the method | 168 |
A method should have only one exit point, and that should be the last statement in the method | 198 |
A method should have only one exit point, and that should be the last statement in the method | 202 |
This statement may have some unnecessary parentheses | 275 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 67 - 67 |
Unnecessary final modifier in final class | 75 - 75 |
Perhaps 'compressedUrlList' could be replaced by a local variable. | 87 |
Perhaps 'cachePeersHash' could be replaced by a local variable. | 88 |
Unnecessary final modifier in final class | 99 - 99 |
Unnecessary final modifier in final class | 185 - 185 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 38 - 38 |
Unnecessary final modifier in final class | 54 - 54 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 77 - 77 |
Unnecessary final modifier in final class | 84 - 84 |
Unnecessary final modifier in final class | 91 - 91 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 88 - 88 |
Unnecessary final modifier in final class | 102 - 102 |
Unnecessary final modifier in final class | 130 - 130 |
Unnecessary final modifier in final class | 171 - 171 |
Unnecessary final modifier in final class | 184 - 184 |
It is a good practice to call super() in a constructor | 204 - 204 |
Unnecessary final modifier in final class | 212 - 212 |
Unnecessary final modifier in final class | 220 - 220 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 31 - 31 |
Violation | Line |
---|---|
Each class should declare at least one constructor | 35 - 35 |
Unnecessary final modifier in final class | 51 - 51 |
A method should have only one exit point, and that should be the last statement in the method | 56 |
A method should have only one exit point, and that should be the last statement in the method | 61 |
Violation | Line |
---|---|
A method should have only one exit point, and that should be the last statement in the method | 110 |
Unnecessary final modifier in final class | 136 - 136 |
A method should have only one exit point, and that should be the last statement in the method | 138 |
A method should have only one exit point, and that should be the last statement in the method | 142 |
Unnecessary final modifier in final class | 168 - 168 |
A method should have only one exit point, and that should be the last statement in the method | 170 |
A method should have only one exit point, and that should be the last statement in the method | 173 |
A method should have only one exit point, and that should be the last statement in the method | 181 |
Unnecessary final modifier in final class | 204 - 204 |
A method should have only one exit point, and that should be the last statement in the method | 206 |
Unnecessary final modifier in final class | 331 - 331 |
It is a good practice to call super() in a constructor | 348 - 348 |
Unnecessary final modifier in final class | 357 - 357 |
Unnecessary final modifier in final class | 366 - 366 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 118 - 118 |
Unnecessary final modifier in final class | 145 - 145 |
Unnecessary final modifier in final class | 157 - 157 |
A method should have only one exit point, and that should be the last statement in the method | 192 |
Unnecessary final modifier in final class | 232 - 232 |
Unnecessary final modifier in final class | 250 - 250 |
Unnecessary final modifier in final class | 257 - 257 |
Violation | Line |
---|---|
Unnecessary final modifier in final class | 67 - 67 |
Unnecessary final modifier in final class | 78 - 78 |
Each class should declare at least one constructor | 87 - 87 |
Unnecessary final modifier in final class | 91 - 91 |
Unnecessary final modifier in final class | 153 - 153 |